Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15
DORMANTno replies

[PATCH v2 7/7] bisect: allows any terms set by user

From: Antoine Delaite <hidden>
Date: 2016-06-15 23:05:18

Matthieu Moy [off-list ref] writes:
quoted
+        if test -s "$GIT_DIR/TERMS_DEFINED"
+        then
+                terms_defined=1
+                get_terms
+                rm -rf "$GIT_DIR/TERMS_DEFINED"
I don't understand why you need to delete this file. I did not review
thoroughly so there may be a reason, but you can help the reader with a
comment here.
I will just complete Louis' answer. We delete it with backward
compatibility with old/new in mind (even if old/new is not merged yet).
For instance, after a old/new mode, if you do a 'bisect start rev1 rev2'
the mode would be bad/good ie the default mode. So if you defined your
terms, we decided it would only be for the following bisection. The next 
'bisect start rev1 rev2' would be in bad/good mode.
But this have to be discuted, do the user have to type 'git bisect terms'
each bisection if he wants to use special terms ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help