Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 3/4] bisect: simplify the add of new bisect terms

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:05:15

Antoine Delaite [off-list ref] writes:
quoted
quoted
+get_terms () {
+        if test -s "$GIT_DIR/BISECT_TERMS"
+        then
+                NAME_BAD="$(sed -n 1p "$GIT_DIR/BISECT_TERMS")"
+                NAME_GOOD="$(sed -n 2p "$GIT_DIR/BISECT_TERMS")"
It is sad that we need to open the file twice.  Can't we do
something using "read" perhaps?
The cost of it is quite low and we see directly what we meant. We didn't 
found a pretty way to read two lines with read.
Should be stg like:

{
	read good
	read bad
} <"$GIT_DIR/BISECT_TERMS"

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help