Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v3 7/7] send-email: suppress leading and trailing whitespaces before alias expansion

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:05:14

Remi Lespinet [off-list ref] writes:
I agree, I'd like to put it right after split_at_commas in a separate
function "trim_list". Is it a good idea even if the function is one
line long ?
Hmph, if I have "A, B, C" and call a function that gives an array of
addresses, treating the input as comma-separated addresses, I would
expect ("A", "B", "C") to be returned from that function, instead of
having to later trim the whitespace around what is returned.

It suggests that split-at-commas _is_ a wrong abstraction, doesn't
it?  In other words, I think whitespace trimming is part of what the
split-a-single-string-into-array-of-addresses helper function should
be doing.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help