Re: [PATCH v6 09/11] ref-filter: move code from 'for-each-ref'

Karthik Nayak [off-list ref] writes:

On 06/08/2015 10:38 PM, Matthieu Moy wrote:

quoted

Karthik Nayak [off-list ref] writes:

quoted

--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c

@@ -1129,7 +56,7 @@ int cmd_for_each_ref(int argc, const char

**argv, const char *prefix)

      memset(&ref_cbdata, 0, sizeof(ref_cbdata));
      ref_cbdata.filter.name_patterns = argv;
-    for_each_rawref(ref_filter_handler, &ref_cbdata);
+    filter_refs(for_each_rawref, &ref_cbdata);

This seems unrelated from the rest of the patch. And you haven't
introduced filter_refs yet!

That definitely is, this happened after fixing merges I suppose.
Ignore it for now, I'll fix it.

I am not sure which one of two copies of 09/11 is being discussed,
but I'll stop here for now.  Most of the patches up to 08/11 looked
sensible, if the renames were a bit too noisy.

Thanks.