Re: [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken

On 06/03/2015 11:20 PM, Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

On Wed, Jun 03, 2015 at 11:51:43AM -0700, Junio C Hamano wrote:

quoted

Jeff King [off-list ref] writes:

quoted

On Wed, Jun 03, 2015 at 03:51:59PM +0200, Michael Haggerty wrote:

quoted

NULL_SHA1 is used to indicate of "invalid SHA-1" throughout our code

s/of/an/ ?

Also possibly s/invalid SHA-1/invalid ref/?

I thought it was trying to express that we use the null sha1 as a
sentinel value throughout the code, no matter if the value came from a
ref or otherwise.

Yeah, an invalid object name, not limited to refs, is correct.

Thanks.

Thanks for all the comments. Taking them into consideration, I suggest
changing the last commit message to

--8<-----------------------------------------------------------------
read_loose_refs(): treat NULL_SHA1 loose references as broken

NULL_SHA1 is used to indicate an "invalid object name" throughout our
code (and the code of other git implementations), so it is vastly more
likely that an on-disk reference was set to this value due to a
software bug than that NULL_SHA1 is the legitimate SHA-1 of an actual
object. Therefore, if a loose reference has the value NULL_SHA1,
consider it to be broken.

Signed-off-by: Michael Haggerty <redacted>
--8<-----------------------------------------------------------------

Since the only comments were about this one commit message, I won't send
an updated patch series to the mailing list unless you request it. You
can also get the patches from my GitHub account [1], branch
"for-each-ref-errors".

Michael

[1] https://github.com/mhagger/git

-- 
Michael Haggerty
mhagger@alum.mit.edu