Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] utf8: NO_ICONV: silence uninitialized variable warning

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:05:10

Jeff King [off-list ref] writes:
So I think your patch is the best option, but it might be good to give
one more look at the callers to be sure we are not missing something.
The two callers both leave the outsz uninitialized and to a human it
is obvious that uninitialized outsz is never used when the function
or macro returns NULL.  It is somewhat sad that we need a useless
assignment to *e to help less than intelligent compilers, but it is
possible that a clever compiler may be able to optimize the useless
assignment away so it might even out in the end ;-)

Will queue.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help