Re: [PATCH 1/2] git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced.
From: Christian Couder <hidden>
Date: 2016-06-15 23:05:10
On Fri, Jun 5, 2015 at 6:34 PM, Louis Stuber [off-list ref] wrote:
Signed-off-by: Louis Stuber <redacted> Signed-off-by: Antoine Delaite <redacted> ---
It looks like this patch applies on top of the bisect old/new series posted by Antoine. This should be stated somewhere.
quoted hunk ↗ jump to hunk
git-bisect.sh | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)diff --git a/git-bisect.sh b/git-bisect.sh index 109bd65..d3d19cb 100644 --- a/git-bisect.sh +++ b/git-bisect.sh@@ -183,6 +183,10 @@ bisect_start() { then echo "$BISECT_BAD" >"$GIT_DIR/BISECT_TERMS" && echo "$BISECT_GOOD" >>"$GIT_DIR/BISECT_TERMS" + if test "$BISECT_BAD" = "new" + then + echo "" > "$GIT_DIR/BISECT_OLDNEWMODE" + fi
I am not sure it's worth it to have both BISECT_TERMS and BISECT_OLDNEWMODE. Also please note that I suggested to Antoine that the BISECT_BAD and BISECT_GOOD variables be renamed to something else, like I already did in some C files.