Re: [PATCH v2 0/2] auto-detect getdelim()

On Tue, Jun 02, 2015 at 05:15:42PM -0400, Eric Sunshine wrote:

This series updates config.mak.uname to define HAVE_GETDELIM on Mac OS X
when appropriate, and adds a configure check for the same.

Changes since v1[1]:

patch 1/2 -- optimize OS X version recognition:

* Use `...` for 'expr' invocation to extract digits from $(uname_R),
  thus only a fork(), rather than gmake $(shell...), which spawns via
  fork()+exec().

* Use 'test' relational operator -ge rather than 'expr >=', along with
  'echo' to compare version number. Since 'test' and 'echo' are
  typically shell builtins, this should be faster than invoking 'expr' a
  second time.

patch 2/2 -- unchanged

Thanks, this version looks good to me.

-Peff