Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [RFCv2 03/16] connect: rewrite feature parsing to work on string_list

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:05:06

Stefan Beller [off-list ref] writes:
Signed-off-by: Stefan Beller <redacted>
---
The change in 2/16 to extract something into a helper was sort-of
guessable without any comment (i.e. perhaps it will gain new callers
in later patches), but a change like this needs to hint why this is
a good thing to do, I would think.

I think you'll be rerolling this anyway due to droppage of 1/16, so
hopefully we'll see the next version a bit better explained than
this round ;-)

Thanks.
 builtin/receive-pack.c | 13 +++++----
 connect.c              | 79 ++++++++++++++++++++++----------------------------
 connect.h              |  2 +-
 upload-pack.c          | 11 +++++--
 4 files changed, 51 insertions(+), 54 deletions(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help