Re: [PATCH/WIP 4/8] am: split out mbox/maildir patches with git-mailsplit

On Fri, May 29, 2015 at 7:05 AM, Eric Sunshine [off-list ref] wrote:

On Wed, May 27, 2015 at 9:33 AM, Paul Tan [off-list ref] wrote:

quoted

@@ -128,13 +190,32 @@ static void am_next(struct am_state *state)
  */
+/**
+ * parse_options() callback that validates and sets opt->value to the
+ * PATCH_FORMAT_* enum value corresponding to `arg`.
+ */
+static int parse_opt_patchformat(const struct option *opt, const char *arg, int unset)
+{
+       int *opt_value = opt->value;
+
+       if (!strcmp(arg, "mbox"))
+               *opt_value = PATCH_FORMAT_MBOX;
+       else
+               return -1;
+       return 0;
+}
+
 struct am_state state;
+int opt_patch_format;

Should these two variables be static?

Whoops. Yes, they should.

Thanks,
Paul