Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit

From: Remi Galan Alfonso <hidden>
Date: 2016-06-15 23:05:05

Junio C Hamano [off-list ref] writes:
Is this sufficient?
If you are going to do something in 2/2 that relies on the format of
this line being correct (as opposed to "noop" or "#" that can have
any garbage on the remainder of the line), wouldn't you want to at
least check $sha1 is sensible?
That's also something that I was wondering, I wrote about it in the
0/2 part of this patch, I wanted some opinion about it.
If there is no opposition on the subject, I will have it ready for
the v3 of the patch.

Quote of that part of the 0/2 for more clarity:
Galan Rémi [off-list ref] writes:
For the 'drop' command, maybe instead of just doing the same thing as
noop, checking if the SHA-1 that supposedly follow does exist could be
a good idea.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help