Thread (10 messages) flat view 10 messages, 4 authors, 2016-06-15

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

From: Remi Galan Alfonso <hidden>
Date: 2016-06-15 23:05:01

Thank you for reviewing the code. 

Eric Sunshine[off-list ref] writes:
quoted
+       # To uppercase
+       checkLevel=$(echo "$checkLevel" | tr '[:lower:]' '[:upper:]')
Is there precedence elsewhere for recognizing uppercase and lowercase
variants of config values?
It seems to be commonly used when parsing options in the C files
through strcasecmp.  For exemple, in config.c:818 :
if (!strcmp(var, "core.safecrlf")) {
	if (value && !strcasecmp(value, "warn")) {
		[...]
However we didn't see any precedence in shell files. Do you think we
should remove it?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help