Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:04:54

Fredrik Medley [off-list ref] writes:
quoted
quoted
+#define ALLOW_TIP_SHA1       01
+static int allow_unadvertised_object_request;
It is better to use "unsigned int" for these bit masks, as we are
not interested in the top-most bit getting special-cased by using a
signed type.  I'll amend this (and the one in upload-pack.c) while
applying, so no need to resend only to correct these two, unless you
have other reasons to reroll.
Sounds like a good idea to change. Please amend it while applying.
Alright, will do.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help