Re: [PATCH v4] mergetools: add winmerge as a builtin tool

On Wed, May 20, 2015 at 09:47:56AM +0200, Sebastian Schuberth wrote:

On Wed, May 20, 2015 at 9:42 AM, David Aguilar [off-list ref] wrote:

quoted

+       OIFS=$IFS
+       IFS='
+'

I guess this is just a formatting issue with the mail export as it should read

IFS=$'\n'

Otherwise looks good to me.

-- 
Sebastian Schuberth

Thanks for the review.

That's actually a literal newline inside a single-quoted string.

I'm not sure how portable $'\n' is, but the '<literal-newline>'
approach is used often in the git code.
-- 
David