Re: [PATCH 2/2] pull: handle --log=<n>

Johannes Schindelin [off-list ref] writes:

Hi Matthieu,

On 2015-05-13 11:38, Matthieu Moy wrote:

quoted

Paul Tan [off-list ref] writes:

quoted

-	--log|--no-log)
-		log_arg=$1 ;;
+	--log|--log=*|--no-log)
+		log_arg="$1" ;;

I think you actually don't need the double quotes here (var=$value works
even if $value has spaces IIRC), but they don't harm and I prefer having
them.

I am far from a shell expert, but IIRC "$1" converts all whitespace to
single spaces.

In most places, $1 is split before being interpreted, but there are
exceptions and actually the RHS of assignment is one of them. Just for
curiosity, I digged a reference:

https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Shell-Substitutions.html
http://unix.stackexchange.com/questions/68694/when-is-double-quoting-necessary

In general, you therefore want to quote arguments, just in case.

Yes, and one benefit of quoting anyway is to avoid having to have the
discussion we're having ;-).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/