Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2 01/12] t5520: implement tests for no merge candidates cases

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:04:40

Paul Tan [off-list ref] writes:
Hi Junio,

On Thu, May 7, 2015 at 10:04 PM, Junio C Hamano [off-list ref] wrote:
quoted
Torsten Bögershausen [off-list ref] writes:
quoted
In other words:
test $(cat file) = file &&
Is there a guarantee that file has a single word?  Can it be empty?
Can it contain "foo bar\n"?
It can, but it should not ;-). But yes, this will need to be quoted as
well to be safe. Whoops.
Yup.  I see that existing test (this script is ancient, isn't it?)
has the same issue of using backticks and not quoting sufficiently.

Perhaps we would want a clean-up-and-modernise step before this
patch to reduce patch noise.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help