Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] t5540: skip under NO_CURL=NoThanks

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:04:40

Jeff King [off-list ref] writes:
On Wed, May 06, 2015 at 09:58:06AM -0700, Junio C Hamano wrote:
quoted
All the other tests in t5xxx series that require http support check
NO_CURL and skip the test, but this one forgot to do so.
Makes sense, though I wonder if this check should just get pushed into
lib-httpd.sh. Surely we can't do anything useful with a web server we
started if we have no curl support? And this seems to support the case:

  $ comm -23 <(git grep -l lib-httpd.sh) <(git grep -l NO_CURL)
  lib-httpd.sh
  t5540-http-push-webdav.sh

After your patch, there is literally no script which includes
lib-httpd.sh but does not respect NO_CURL.
Makes perfect sense.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help