Re: [PATCH] git-gui: sort entries in tclIndex

Looping in Pat (git-gui maintainer).

Am 15.04.2015 um 09:22 schrieb Olaf Hering:

Ping?

On Tue, Feb 10, Olaf Hering wrote:

quoted

Ping?

On Mon, Jan 26, Olaf Hering wrote:

quoted

ALL_LIBFILES uses wildcard, which provides the result in directory
order. This order depends on the underlying filesystem on the
buildhost. To get reproducible builds it is required to sort such list
before using them.

Signed-off-by: Olaf Hering <redacted>
---
  git-gui/Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-gui/Makefile b/git-gui/Makefile
index cde8b2e..7564a18 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile

@@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
  	 rm -f $@ ; \
  	 echo '# Autogenerated by git-gui Makefile' >$@ && \
  	 echo >>$@ && \
-	 $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
+	 $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
  	 echo >>$@ ; \
  	fi