Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v2 2/5] log: honor log.merges= option

From: Koosha Khajehmoogahi <hidden>
Date: 2016-06-15 23:04:23


On 04/04/2015 10:00 PM, Junio C Hamano wrote:
Koosha Khajehmoogahi [off-list ref] writes:
quoted
From: Junio C Hamano <redacted>

[kk: wrote commit message]
Ehh, what exactly did you write ;-)?

I think the most important thing that needs to be explained by the
log message for this change is that the variable is honored only by
log and it needs to explain why other Porcelain commands in the same
"log" family, like "whatchanged", should ignore the variable.
So, what would be the reason? 
 
I think that we must not to allow format-patch and show to be
affected by this variable, because it is silly if log.merges=only
broke format-patch output or made "git show" silent.  But I didn't
think about others.  Whoever is doing this change needs to explain
in the log message the reason why it was decided that only "git log"
should pay attention to it.
  

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help