Re: [PATCH V2 4/6] wt-status.c: fix a memleak
From: Eric Sunshine <hidden>
Date: 2016-06-15 23:04:18
On Fri, Mar 27, 2015 at 6:32 PM, Stefan Beller [off-list ref] wrote:
quoted hunk ↗ jump to hunk
In any code path of shorten_unambiguous_ref the return value is a xstrdup(some string), so it is safe to free the variable `base` in any codepath. Signed-off-by: Stefan Beller <redacted> --- wt-status.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/wt-status.c b/wt-status.c index 853419f..9d2a349 100644 --- a/wt-status.c +++ b/wt-status.c@@ -1576,6 +1576,8 @@ static void wt_shortstatus_print_tracking(struct wt_status *s) color_fprintf(s->fp, header_color, "]"); fputc(s->null_termination ? '\0' : '\n', s->fp); + + free((char *)base);
There's an early 'return' before this point (at line 1560) which will leak 'base', so this is an unreliable fix. A better solution would be to free(base) immediately after it's final use (before the early 'return').
} void wt_shortstatus_print(struct wt_status *s) -- 2.3.0.81.gc37f363