Thread (26 messages) flat view 26 messages, 5 authors, 2016-06-15

Re: [PATCH 00/14] numparse module: systematically tighten up integer parsing

From: Duy Nguyen <hidden>
Date: 2016-06-15 23:04:11

On Wed, Mar 18, 2015 at 4:47 PM, Michael Haggerty [off-list ref] wrote:
quoted
Thank you for doing it. I was about to write another number parser and
you did it :D Maybe you can add another patch to convert the only
strtol in upload-pack.c to parse_ui. This place should accept positive
number in base 10, plus sign is not accepted.
If the general direction of this patch series is accepted, I'll
gradually try to go through the codebase, replacing *all* integer
parsing with these functions. So there's no need to request particular
callers of strtol()/strtoul() to be converted; I'll get to them all
sooner or later (I hope).
Good to know. No there's no hurry in converting this particular place.
It's just tightening things up, not bug fixing or anything.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help