Re: [PATCH/GSoC/RFC] fetch: git fetch --deepen

Duy Nguyen [off-list ref] writes:

On Sat, Mar 14, 2015 at 12:35 PM, Junio C Hamano [off-list ref] wrote:

quoted

Dongcan Jiang [off-list ref] writes:

quoted

What does (you) exactly mean in [1]? The local branch or the local
remote ref?

As this operation is not about moving _any_ refs, whether local
branches or remote-tracking branches, any ref that used to point at
commit B before you executed "fetch --deepen" would point at the
same commit after the command finishes.

That would make it harder to implement "fetch --deepen" than the
version that moves refs if they are updated.

The comment you are responding to was in the context of "What does
the illustrated 'your' history mean?  Is it a history of a single
ref (if so in which repository)?" to clarify that the example was
not fetching _new_ history (and with the RFC/POC design that was
posted, my understanding is that deepen was meant to only deepen).

The paragraph you are reacting to is not an endorsement for that
"only deepen, never advance" design. It merely is a clarification of
the explanation that was in the paragraph that follows.

And I think what Dongcan
implemented moves refs. From the user point of view, I think it's ok
with either version, so the one that's easier to implement wins.

quoted

The "you" does not explicitly depict any ref, because the picture is
meant to illustrate _everything_ the repository at the receiving end
of "fetch" has.  It used to have two commits, A and B (and the tree
and blob objects necessary to complete these two commits).  After
deepening the history by one commit, it then will have commit A^ and
its trees and blobs.

quoted

[1] http://article.gmane.org/gmane.comp.version-control.git/212950