Thread (4 messages) 4 messages, 2 authors, 2016-06-15

Re: [PATCH 1/3] connect.c: Fix memory leak

flat view

From: Torsten Bögershausen <hidden>
Date: 2016-06-15 23:04:06

On 2015-03-09 17.58, Stefan Beller wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Stefan Beller <redacted>
---
 connect.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/connect.c b/connect.c
index ce0e121..6090211 100644
--- a/connect.c
+++ b/connect.c
@@ -739,6 +739,7 @@ struct child_process *git_connect(int fd[2], const char *url,
 
 				free(hostandport);
 				free(path);
+				free(conn);
 				return NULL;
 			} else {
 				ssh = getenv("GIT_SSH_COMMAND");
Nice catch, thanks.
(Even if it is not sooo serious today, the current implementation of Git just dies
when connection is NULL)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help