Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v3 2/3] sha1_file: implement changes for "cat-file --literally -t"

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:04:05

karthik nayak [off-list ref] writes:
What parse_sha1_header() does to get the type is just find the first
occurrence of a " " manually and store everything before it as the
type. Then it finds the size of the object if needed. And finally
returns the type by calling type_from_string(). This is where we get
the undefined type error.
Yes, exactly.  The change illustrated in $gmane/264420 may be
incomplete and some calls from the sha1_object_info_extended() after
that change may still need to further be tweaked to pay attention to
LOOKUP_LITERALLY bit; for example, parse_sha1_header() may want to
learn not to barf when seeing an unexpected typename in the header
when the caller asks to look up "literally".

I thought I already said that; sorry if I forgot.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help