Re: [PATCH] grep: correct help string for --exclude-standard
From: Duy Nguyen <hidden>
Date: 2016-06-15 23:03:58
On Wed, Mar 4, 2015 at 6:26 PM, Jeff King [off-list ref] wrote:
quoted
quoted
It might be nice if parseopt had a PARSE_OPT_NEGHELP option or something to show the "--no-" form.Regardless, yes it would be nice to have something like this. I think there are places that can make use of this.Grepping around, it looks like the best form would be an OPT_NEGBOOL that acts like a boolean but negates the truth value, and advertises the negative form. We have a lot of: OPT_BOOL('n', "no-checkout", &option_no_checkout, N_("don't create a checkout")) where countermanding an earlier "--no-checkout" has to be spelled as "--no-no-checkout", rather than "--checkout". If we could write: OPT_NEGBOOL('n', "checkout", ...) that would be nicer. But the short option is a bit weird. We'd want: -n: option_no_checkout=true --checkout: option_no_checkout=false --no-checkout: option_no_checkout=true That is, we flip the sense of the long option, but the short option still yields "true". I think that would be useful, but it sure is weird to explain.
Yeah it looks confusing.. How about leaving that first arg as the short option "checkout" and move 'n' elsewhere? Something like this OPT_NEGBOOL(0, "checkout", 'n', ....) -- Duy