Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH] reset: allow "-" short hand for previous commit

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:03:58

Possibly related (same subject, not in this thread)

Matthieu Moy [off-list ref] writes:
Sudhanshu Shekhar [off-list ref] writes:
quoted
From: SudShekhar <redacted>
Please, set your configuration to have the same identity for commit and
send-email. It seems your commiter ID (user.name) does not contain your
last name.
Actually, the token does not match either of the two names; it looks
like two names smashed together into a single nickname token.
quoted
builtin/reset.c | 2 ++
Doesn't this deserve a test?

+		if(!strcmp(argv[0],"-"))
+			argv[0]="@{-1}";

Wrong spacing (around = and after ,).
What should worry us even more is what the user would get when @{-1}
does not resolve to something the command can use.  It would be bad
if we give an error message with @{-1} in it that the user never
typed (and may not even understand what it means).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help