Re: [PATCH v2] diff --shortstat --dirstat: remove duplicate output
From: Torsten Bögershausen <hidden>
Date: 2016-06-15 23:03:56
On 2015-03-01 08.39, Mårten Kongstad wrote: [] index ed7e093..128f7bf 100755
quoted hunk ↗ jump to hunk
--- a/t/t4047-diff-dirstat.sh +++ b/t/t4047-diff-dirstat.sh@@ -973,4 +973,15 @@ test_expect_success 'diff.dirstat=future_param,0,lines should warn, but still wo test_i18ngrep -q "diff\\.dirstat" actual_error ' +test_expect_success '--shortstat --dirstat should output only one dirstat' ' + git diff --shortstat --dirstat=changes HEAD^..HEAD >actual_diff_shortstat_dirstat_changes && + test $(grep -c " dst/copy/changed/$" actual_diff_shortstat_dirstat_changes) = 1 &&
How portable is the "grep -c" usage ? (I don't now it either, do we have other opinions ?), but the following seems to be more "Git-style": test_expect_success '--shortstat --dirstat should output only one dirstat' ' git diff --shortstat --dirstat=changes HEAD^..HEAD >actual_diff_shortstat_dirstat_changes && grep " dst/copy/changed/$" actual_diff_shortstat_dirstat_changes >actual && test_line_count = 1 actual