Re: [PATCH 1/2] git-send-email.perl: support no- prefix with older GetOptions

On Sun, Feb 15, 2015 at 1:51 AM, Kyle J. McKay [off-list ref] wrote:

On Feb 14, 2015, at 22:32, Brandon Casey wrote:

quoted

On Fri, Feb 13, 2015 at 12:19 PM, Junio C Hamano [off-list ref]
wrote:

quoted

From: "Kyle J. McKay" <redacted>

Only Perl version 5.8.0 or later is required, but that comes with
an older Getopt::Long (2.32) that does not support the 'no-'
prefix.  Support for that was added in Getopt::Long version 2.33.

Since the help only mentions the 'no-' prefix and not the 'no'
prefix, add explicit support for the 'no-' prefix when running
with older GetOptions versions.

ultra-ultra-nit: s/when running/for when running/

So it would say "add explicit support for the 'no-'prefix for when running
with"...  That doesn't make sense to me.

quoted

The current wording
makes it sound like the explicit support is only enabled when running
with older GetOpt versions.

How about this instead:

Since the help only mentions the 'no-' prefix and not the 'no'
prefix, add explicit support for the 'no-' prefix to support
older GetOptions versions.

Works for me.

-Brandon