Thread (19 messages) flat view 19 messages, 3 authors, 2016-06-15

Re: [PATCH v2 03/12] struct ref_update: move "have_old" into "flags"

From: Stefan Beller <hidden>
Date: 2016-06-15 23:03:48

On Thu, Feb 12, 2015 at 3:12 AM, Michael Haggerty [off-list ref] wrote:
-       int flags; /* REF_NODEREF? */
-       int have_old; /* 1 if old_sha1 is valid, 0 otherwise */
+       /*
+        * One or more of REF_HAVE_OLD, REF_NODEREF,
+        * REF_DELETING, and REF_IS_PRUNING:
+        */
+       int flags;
Nit:
I'd find it more readable if it would be:
    /*
     * One or more of
     * REF_HAVE_OLD,
     * REF_NODEREF,
     * REF_DELETING,
     * REF_IS_PRUNING:
     * whose definition is found at the top of this file.
     */

With or without the nit:
Reviewed-by: Stefan Beller <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help