Re: [PATCH] cat-file: add short option '-c' for 'cat-file --textconv'
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:03:26
Alexander Kuleshov [off-list ref] writes:
quoted hunk
Signed-off-by: Alexander Kuleshov <redacted> --- Documentation/git-cat-file.txt | 5 +++-- builtin/cat-file.c | 4 ++-- t/t8007-cat-file-textconv.sh | 10 ++++++++++ 3 files changed, 15 insertions(+), 4 deletions(-)diff --git a/Documentation/git-cat-file.txt b/Documentation/git-cat-file.txt index f6a16f4..b346a5d 100644 --- a/Documentation/git-cat-file.txt +++ b/Documentation/git-cat-file.txt@@ -9,14 +9,14 @@ git-cat-file - Provide content or type and size information for repository objec SYNOPSIS -------- [verse] -'git cat-file' (-t | -s | -e | -p | <type> | --textconv ) <object> +'git cat-file' (-t | -s | -e | -p | <type> | (-c | --textconv) ) <object>
Do we use "-c" for a shorthand for "--textconv" anywhere else? Is there any other command that has "--textconv" where "-c" does not mean "--textconv"? Or worse yet, where "-c" already means something completely different from "--textconv"? Unlike end-user facing Porcelain commands, plumbing commands are primarily meant to be used in scripts, and I am not sure how much benefit we are getting by introducing new short options to them. Ancient plumbing commands do have many single-letter options but they were added back when more modern set of end-user facing Porcelain commands did not exist.