Re: [PATCH 0/5] Fix the Visual Studio 2008 .sln generator
From: Philip Oakley <hidden>
Date: 2016-06-15 23:03:21
From: "Philip Oakley" <redacted>
Potential Windows developers are likely to be using Visual Studio as their IDE. The tool stack required for Windows can be tortuous as it crosses the boundaries between platforms and philosophies. This patch series seeks to maintain the tools that could assist such developers. In particular, those tools that generate an initial Visual Studio project (.sln ) file. The .sln generator in contrib began to break when internationalisation introduced an extra -o option. This recently worsened with the addition of invalidcontinue.obj for 'improved POSIX compatibility'. I hacked a bit when I first attempted to use the VS IDE and noticed the i18n issue. I didn't completely solve all my issues because of further issues with VS2010 Express, so no patches were submitted at the time. Now, with a fresh copy of VS20008 Express, I saw the additional problem of the addition of the invalidcontinue.obj reference causing the .sln generation to fail. The series has been tested against both recent git/git and msysgit/git. Both produce good VS2008 .sln project files though only msysgit/git compiles without error, both using the msysgit msvc-build script. Those compile errors are not related to this patch series.
Now, having tried using the VS project output for some follow on work, I've found that the resultant .sln file is incomplete, though does compile fine as noted. Investigation has shown that the 'failure' to provide a complete Git project would apper to have begun somewhere between v1.7.9 and v1.8.0. V1.7.9 has 'git', while v1.8.0 doesn't (along with other missing artefacts). Looks like firther fixes are needed once the cause is determined.
An initial RFC version was discussed on the msysgit list https://groups.google.com/forum/#!topic/msysgit/3MQ_NMNM390 or http://thread.gmane.org/gmane.comp.version-control.msysgit/21132. The final patch adds a poorman's --verbose by a few carefully selected commented out debug print statements to assist others in resolving future breakages. I've cc'd those who have contributed or patched the engine.pl, or appear to be interested via a $gmane search, who can hopefully comment. Philip Oakley (5): engine.pl: Fix i18n -o option in msvc buildsystem generator engine.pl: Properly accept quoted spaces in filenames engine.pl: ignore invalidcontinue.obj which is known to MSVC vcbuild/readme: Improve layout and reference msvc-build script engine.pl: provide more debug print statements compat/vcbuild/README | 27 +++++++++++++++++++-------- contrib/buildsystems/engine.pl | 27 +++++++++++++++++++++------ 2 files changed, 40 insertions(+), 14 deletions(-) --
Philip -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.