Thread (1 message) 1 message, 1 author, 2016-06-15

Re: no-xmailer tests fail under Mac OS

From: Luis Henriques <hidden>
Date: 2016-06-15 23:03:16

Jeff King [off-list ref] writes:
On Thu, Dec 11, 2014 at 02:11:04PM -0800, Junio C Hamano wrote:
quoted
Jeff King [off-list ref] writes:
quoted
On Fri, Dec 05, 2014 at 11:07:37PM -0800, Michael Blume wrote:
quoted
quoted
Ah, right, we might be looking for 0 sometimes. The right way to do it
without destroying the &&-chaining is:

  { grep ^X-Mailer: out || true } &&
  test_line_count = $expected mailer
Hmm, it doesn't look like that helper is &&-chained though? So it
seems like we could just do without the &&
You're right, but that is IMHO a bug. We would not notice if send-email
or format-patch barfed, and we are expecting to find no X-Mailer (we
wouldn't, but for the wrong reason).
Let me patch this up further by amending the SQUASH??? at the tip.

 t/t9001-send-email.sh | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
[...]
Yeah, looks good to me.

-Peff
Same here.  Thanks a lot for fixing this.

Cheers,
--
Luís
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help