Thread (1 message) 1 message, 1 author, 2016-06-15

Re: no-xmailer tests fail under Mac OS

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:03:15

Michael Blume [off-list ref] writes:
Failures start from

commit d2384abff7a6181fd7b9a51af7e780aa21e5cb8d (refs/bisect/bad)
Author: Luis Henriques [off-list ref]
Date:   Thu Dec 4 19:11:30 2014 +0000

    test/send-email: --[no-]xmailer tests

    Add tests for the --[no-]xmailer option.

    Signed-off-by: Luis Henriques [off-list ref]
    Signed-off-by: Junio C Hamano [off-list ref]

but continue with Junio's SQUASH??? commit at b728d078
I missed this bit in the patch you pointed out:

+       test "z$(grep ^X-Mailer: out | wc -l)" = "z$expected"

which depends on "wc -l" not to add any extra whitespace around its
count.  We know that some implementations do, and we should be using

	test $(grep xxx | wc -l) -eq $expected

or something, or test_line_count.

Thanks for noticing.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help