Re: [PATCH 06/23] expire_reflog(): exit early if the reference has no reflog

On 12/05/2014 12:53 AM, Jonathan Nieder wrote:

Michael Haggerty wrote:

quoted

[Subject: expire_reflog(): exit early if the reference has no reflog]

The caller moves on to expire other reflogs, so it's not exiting.
"return early", maybe?

Except the function already returned early.  I think the purpose of
this patch is to simplify the no-reflog case by handling it separately.

Anyway, that's just nitpicking about the subject line.  With
s/exit/return/ it should be clear that this is a refactoring change,
which for someone looking at the shortlog is the important thing.

Good suggestion. I will change the commit message.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu