Re: [PATCH] compat: convert modes to use portable file type values

On Sun, Nov 30, 2014 at 9:41 AM, David Michael [off-list ref] wrote:

+int git_stat(const char *path, struct stat *buf)
+{
+       int rc;
+       rc = stat(path, buf);
+       if (buf != NULL)

It's a minor thing, but maybe test "!rc" instead of "buf != NULL"?

+               buf->st_mode = mode_native_to_git(buf->st_mode);
+       return rc;
+}

-- 
Duy