Re: [PATCH] git-sh-setup.sh: use dashdash with basename call
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:03:06
Dan Wyand [off-list ref] writes:
Calling basename on a argument that starts with a dash, like a login shell, will result in an error. This patch adds '--' before the argument so that the argument is interpreted properly. ---
Makes sense. Please sign-off your patch (see Documentation/SubmittingPatches).
quoted hunk
git-sh-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/git-sh-setup.sh b/git-sh-setup.sh index 9447980..5cdae33 100644 --- a/git-sh-setup.sh +++ b/git-sh-setup.sh@@ -81,7 +81,7 @@ if test -n "$OPTIONS_SPEC"; then echo exit $? )" else - dashless=$(basename "$0" | sed -e 's/-/ /') + dashless=$(basename -- "$0" | sed -e 's/-/ /') usage() { die "usage: $dashless $USAGE" }