Re: [PATCH v5 1/1] refs.c: use a stringlist for repack_without_refs
From: Jonathan Nieder <hidden>
Date: 2016-06-15 23:03:00
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH v5 1/1] refs.c: use a stringlist for repack_without_refs · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH v5 1/1] refs.c: use a stringlist for repack_without_refs · Stefan Beller <hidden>
Stefan Beller wrote:
Change-Id: Id7eaa821331f2ab89df063e1e76c8485dbcc3aed
Change-id snuck in. [...]
quoted hunk ↗ jump to hunk
--- a/refs.h +++ b/refs.h@@ -163,8 +163,16 @@ extern void rollback_packed_refs(void); */ int pack_refs(unsigned int flags); -extern int repack_without_refs(const char **refnames, int n, - struct strbuf *err); +/* + * Remove the refs listed in 'without' from the packed-refs file. + * On error, packed-refs will be unchanged, the return value is + * nonzero, and a message about the error is written to the 'err' + * strbuf. + * + * The refs in 'without' may have any order.
Tiny nit: this makes me wonder what the order represents --- how do I pick which order for the refs in without to have? I think the idea is just that 'without' doesn't have to be sorted (it's a shame we don't have separate sorted string list and unsorted string list types or a string_list_sorted() helper to catch bad callers early to functions that care). One way to say that would be Remove the refs listed in the unsorted string list 'without' from the packed-refs file. On error, [...]
+ * The err buffer must not be omitted.
s/buffer/strbuf/, or s/The err buffer/'err'/ s/omitted/NULL/ With the Change-Id dropped, and with or without the above comment nits addressed, Reviewed-by: Jonathan Nieder <redacted>