Re: [PATCH] t1410: fix breakage on case-insensitive filesystems
From: Andreas Schwab <hidden>
Date: 2016-06-15 23:02:56
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] t1410: fix breakage on case-insensitive filesystems · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] t1410: fix breakage on case-insensitive filesystems · Johannes Sixt <hidden>
- 2016-06-15 · Re: [PATCH] t1410: fix breakage on case-insensitive filesystems · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH] t1410: fix breakage on case-insensitive filesystems · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] t1410: fix breakage on case-insensitive filesystems · Johannes Sixt <hidden>
Johannes Sixt [off-list ref] writes:
quoted hunk
diff --git a/compat/mingw.c b/compat/mingw.c index 2ee3fe3..fc64b73 100644 --- a/compat/mingw.c +++ b/compat/mingw.c@@ -312,7 +312,7 @@ int mingw_open (const char *filename, int oflags, ...) return -1; fd = _wopen(wfilename, oflags, mode); - if (fd < 0 && (oflags & O_CREAT) && errno == EACCES) { + if (fd < 0 && (oflags & (O_WRONLY|O_RDWR)) && errno == EACCES) {
O_WRONLY and O_RDWR aren't flags, but two values of a 2-bit field (O_ACCMODE). Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."