Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] SubmittingPatches: fix an inconsistency

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:02:56

slavomir vlcek [off-list ref] writes:
The 'SubmittingPatches' document contains a small inconsistency
 in a patch-email sending procedure.

Not a big thing,
but a newcomer could get confused.

Please,
also consider adding the definition/explanation for all the branches available
at the beginning of this document (and maybe even what their names stand for).
Thanks.

Signed-off-by: slavomir vlcek <redacted>
---

From 74859712cf805663e3863686bdc09511c74b207b Mon Sep 17 00:00:00 2001
From: slavomir vlcek <redacted>
Date: Thu, 13 Nov 2014 00:18:39 +0100
Subject: [PATCH] SubmittingPatches: fix an inconsistency

At line 213 there was an instruction:
  "re-send it with "To:" set to the maintainer [*1*] and "cc:" the list [*2*]"

and this instruction got repeated once more in the document (line 340):
  "Send it to the list and cc the maintainer."

This inconsistency was solved by editing the second occurance.
---
The same comment applies to the log message part.

Will queue; no need to resend.

Thanks.
quoted hunk
 Documentation/SubmittingPatches | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index e6d46ed..fa71b5f 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -337,7 +337,7 @@ suggests to the contributors:
      spend their time to improve your patch.  Go back to step (2).
 
  (4) The list forms consensus that the last round of your patch is
-     good.  Send it to the list and cc the maintainer.
+     good.  Send it to the maintainer and cc the list.
 
  (5) A topic branch is created with the patch and is merged to 'next',
      and cooked further and eventually graduates to 'master'.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help