Re: [PATCH] git-imap-send: use libcurl for implementation

Ramsay Jones [off-list ref] writes:

quoted

In order to suppress a sparse warning about "using sizeof on a
function", we use the same solution used in commit 9371322a6
("sparse: suppress some "using sizeof on a function" warnings",
06-10-2013) which solved exactly this problem for the other commands
using libcurl.

Although it doesn't hurt, I don't think this 'problem' deserves
so many (or any) inches in the commit message. ;-)

Use smaller line pitch, then? ;-) I am sure myself 6 months down the
road as a "git show" reader of this patch would appreciate these
five lines when I scratch my head looking at the Makefile changes.

quoted

Signed-off-by: Bernhard Reiter <redacted>
Signed-off-by: Ramsay Jones <redacted>

Since I didn't actually review this patch, or make any significant
contribution to the code (it's not even enough to be copyright-able!),
then this 'Signed-off-by:' should not be included. At *most* you might
want to put a 'Helped-by:' _prior_ to your sign-off.

Yes, that is the appropriate thing to do, I would think.

Thanks.