Re: [PATCH v2 1/2] git_connect: set ssh shell command in GIT_SSH_CMD

* Jeff King, 2014-11-09 :

Thanks, I like this much better. The name GIT_SSH_CMD is not too bad.
Personally, of the two (GIT_SSH and GIT_SSH_CMD) I would expect the
"_CMD" form to be the one that does not use the shell.

Right, except of course we're stuck with the compatibility issue in any
case.

But I do not really have a better suggestion for the name, so perhaps
it's OK.

Could also be GIT_SSH_SHELLCMD, to denote that this is a *shell*
command...

Parsing complications aside, you cannot even know in git which ssh is
going to be run until the shell code is executed. I think either we have
to leave the responsibility for munging "-p" into "-P" on the side of
the user's shell snippet

That sounds like a reasonable approach, and leaves us with the simpler
change (that splitting circuitry was admittely a bit awkward...)

Thomas.