Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH] use child_process_init() to initialize struct child_process variables

From: Jeff King <hidden>
Date: 2016-06-15 23:02:51

On Wed, Nov 05, 2014 at 01:35:21PM -0000, Philip Oakley wrote:
quoted
quoted
 2. Including two lines, like:
[...]
I believe that the 'two HEADs' mechanism would also fall foul of the
'duplicate refs' warning (untested).
It didn't in my very brief testing of what I posted above, but maybe
there is some other case that triggers it that I didn't exercise.

I grepped through the code and the only "duplicate ref" warning I see
comes from the refs.c code, which comes from commit_packed_refs(). If
the duplicate line is HEAD, I think it shouldn't trigger that, as it is
not a regular ref. That would explain why I didn't see it in my testing.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help