Re: [PATCH v2] diff-highlight: exit when a pipe is broken

Jeff King [off-list ref] writes:

On Tue, Nov 04, 2014 at 03:01:12PM -0500, John Szakmeister wrote:

quoted

While using diff-highlight with other tools, I have discovered that Python
ignores SIGPIPE by default.  Unfortunately, this also means that tools
attempting to launch a pager under Python--and don't realize this is
happening--means that the subprocess inherits this setting.  In this case, it
means diff-highlight will be launched with SIGPIPE being ignored.  Let's work
with those broken scripts by restoring the default SIGPIPE handler.

Signed-off-by: John Szakmeister <redacted>
---
Incorporates feedback from Jeff King and now we just restore the default signal
handler using the correct case of 'DEFAULT'.

Thanks, this version looks much simpler. :)

Acked-by: Jeff King <redacted>

Thanks, both.  The patch looks good.  Will queue.