Re: [PATCH 01/19] dir.c: optionally compute sha-1 of a .gitignore file

On Wed, Oct 29, 2014 at 12:37 AM, Torsten Bögershausen [off-list ref] wrote:

On 2014-10-27 13.10, Nguyễn Thái Ngọc Duy wrote:
[]
Nice serious, I can imagine to test & benchmark it (so I assume there is a branch
on github or so ?)

It's on 'pu' now. There's a branch on my github repo, but it has some
extra debugging on top, so 'pu' is probably the best option.

Another thing:
Can we switch the feature off?

It could be nice to benchmark with and without the cache on the command line,
and besides that we may want to switch it on or off, depending on the file system.
I think this can be easily done when reading and writing the index file.
(But may cost a config variable, core.dirmtime ??)

You can permanently switch it off with "git update-index
--no-untracked-cache". An option to temporarily disable it is not
available. I'll add an environment variable for that.

For a normal case, "update-index --untracked-cache" would test if the
OS/FS supports this before enabling it. If the repo is moved to
another fs, or being used by a different OS, then the user has to
manually disable it first. I don't know what we can do here, maybe
record uname and filesystem in the index as well..

quoted

diff --git a/dir.c b/dir.c
+static int add_excludes(const char *fname, const char *base, int baselen,
+                     struct exclude_list *el, int check_index,
+                     struct sha1_stat *ss, int ss_valid)

Cosmetic question: does it make sense to write

struct sha1_stat *sha1_stat
or
struct sha1_stat *s_stat

Noted.


-- 
Duy