Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] mergetools/meld: do not rely on the output of `meld --help`

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:02:43

David Aguilar [off-list ref] writes:
We cannot rely on the output of `meld --help` when determining
whether or not meld understands the --output option.

Newer versions of meld print a generic help message that does not
mention --output even though it is supported.
This obviously breaks those who have happily been using their
installed version of meld that understands and shows --output in the
help text.  Is that a minority that is rapidly diminishing?

I would understand it if the change were

 - a configuration tells us to use or not use --output; when it is
   set, then we do not try auto-detect by reading --help output

 - when that new configuration is not set, we keep the current code
   to read --help output, which may fail for recent meld but that is
   not a regression.

When versions of meld that support --output but do not mention it in
their --help text are overwhelming majority, we would want to flip
the fallback codepath from "read --help and decide" to "assume that
--output can be used", but I do not know if now is the time to do
so.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help