Re: [PATCH] Initialise hash variable to prevent compiler warnings
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:02:42
Felipe Franciosi [off-list ref] writes:
The 'hash' variable in test-hashmap.c is not initialised properly which causes some 'gcc' versions to complain during compilation.
FNV/I/IDIV10/0 covers all the possibilities of (method & 3), I would have to say that the compiler needs to be fixed. Or insert "default:" just before "case HASH_METHOD_0:" line? I dunno.
quoted hunk
Signed-off-by: Felipe Franciosi <redacted> --- test-hashmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/test-hashmap.c b/test-hashmap.c index 07aa7ec..cc2891d 100644 --- a/test-hashmap.c +++ b/test-hashmap.c@@ -47,7 +47,7 @@ static struct test_entry *alloc_test_entry(int hash, char *key, int klen, static unsigned int hash(unsigned int method, unsigned int i, const char *key) { - unsigned int hash; + unsigned int hash = 0; switch (method & 3) { case HASH_METHOD_FNV: