Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [PATCH] completion: ignore chpwd_functions when cding

From: Brandon Turner <hidden>
Date: 2016-06-15 23:02:40

Possibly related (same subject, not in this thread)

On Wed, Oct 8, 2014 at 1:12 PM, Junio C Hamano [off-list ref] wrote:

Can you mention that this is abomination limited only to zsh
somewhere in the log message?  Or does bash share the same glitch?

If this is limited to zsh, I wonder if we can take advantage of the
fact that we have git-completion.bash and git-completion.zsh to
avoid contaminating shared part of the code.
I'm going to submit two versions of the patch:
v2 - addresses the log message, but the patch still applies to bash
and zsh
v3 - moves the change to git-completion.zsh as an override, bash is
unaffected
From my testing, bash is unaffected, so v3 would be an ok fix.  Since
we cannot control what functions users add to chpwd_functions, v2 might
make more sense.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help