[PATCH 02/24] wrapper.c: remove/unlink_or_warn: simplify, treat ENOENT as success
flat view
DORMANTno replies
From: Jonathan Nieder <hidden>
Date: 2016-06-15 23:02:38
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Ronnie Sahlberg <redacted> Date: Wed, 16 Jul 2014 11:01:18 -0700 Simplify the function warn_if_unremovable slightly. Additionally, change behaviour slightly. If we failed to remove the object because the object does not exist, we can still return success back to the caller since none of the callers depend on "fail if the file did not exist". Signed-off-by: Ronnie Sahlberg <redacted> Signed-off-by: Jonathan Nieder <redacted> --- Change since v21: - adjust caller to remove redundant errno check git-compat-util.h | 7 +++++-- refs.c | 2 +- wrapper.c | 14 ++++++-------- 3 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index b6f03b3..611e77b 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h@@ -706,11 +706,14 @@ void git_qsort(void *base, size_t nmemb, size_t size, /* * Preserves errno, prints a message, but gives no warning for ENOENT. - * Always returns the return value of unlink(2). + * Returns 0 on success which includes trying to unlink an object that does + * not exist. */ int unlink_or_warn(const char *path); /* - * Likewise for rmdir(2). + * Preserves errno, prints a message, but gives no warning for ENOENT. + * Returns 0 on success which includes trying to remove a directory that does + * not exist. */ int rmdir_or_warn(const char *path); /*
diff --git a/refs.c b/refs.c
index 7235574..d0565b1 100644
--- a/refs.c
+++ b/refs.c@@ -2557,7 +2557,7 @@ static int delete_ref_loose(struct ref_lock *lock, int flag) lock->lk->filename[i] = 0; err = unlink_or_warn(lock->lk->filename); lock->lk->filename[i] = '.'; - if (err && errno != ENOENT) + if (err) return 1; } return 0;
diff --git a/wrapper.c b/wrapper.c
index bc1bfb8..c9605cd 100644
--- a/wrapper.c
+++ b/wrapper.c@@ -429,14 +429,12 @@ int xmkstemp_mode(char *template, int mode) static int warn_if_unremovable(const char *op, const char *file, int rc) { - if (rc < 0) { - int err = errno; - if (ENOENT != err) { - warning("unable to %s %s: %s", - op, file, strerror(errno)); - errno = err; - } - } + int err; + if (!rc || errno == ENOENT) + return 0; + err = errno; + warning("unable to %s %s: %s", op, file, strerror(errno)); + errno = err; return rc; }
--
2.1.0.rc2.206.gedb03e5