Re: [PATCH v3] git tag --contains: avoid stack overflow
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:02:35
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH v3] git tag --contains: avoid stack overflow · Andreas Schwab <hidden>
- 2016-06-15 · Re: [PATCH v3] git tag --contains: avoid stack overflow · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH v3] git tag --contains: avoid stack overflow · Andreas Schwab <hidden>
- 2016-06-15 · Re: [PATCH v3] git tag --contains: avoid stack overflow · Stepan Kasal <hidden>
- 2016-06-15 · Re: [PATCH v3] git tag --contains: avoid stack overflow · Jeff King <hidden>
Andreas Schwab [off-list ref] writes:
Jeff King [off-list ref] writes:quoted
But if we do want to keep it, does bumping it to 128 (and bumping the 4000 to 8000 in the test below it) work?It works for all architectures supported by the openSUSE build service. https://build.opensuse.org/package/show/home:AndreasSchwab:f/git Andreas.
So this on top of cbc60b67 (git tag --contains: avoid stack overflow, 2014-04-24) and merge it to maint and upwards? t/t7004-tag.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index e4ab0f5..c564197 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh@@ -1424,7 +1424,7 @@ EOF ' run_with_limited_stack () { - (ulimit -s 64 && "$@") + (ulimit -s 128 && "$@") } test_lazy_prereq ULIMIT 'run_with_limited_stack true'
@@ -1433,7 +1433,7 @@ test_lazy_prereq ULIMIT 'run_with_limited_stack true' test_expect_success ULIMIT '--contains works in a deep repo' ' >expect && i=1 && - while test $i -lt 4000 + while test $i -lt 8000 do echo "commit refs/heads/master committer A U Thor <author@example.com> $((1000000000 + $i * 100)) +0200