Re: [PATCH] credential-cache: close stderr in daemon process
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:02:32
Jeff King [off-list ref] writes:
Squash this in?
Yeah, I did a crude one without _errno() while sending the report; will replace. Thanks.
quoted hunk
diff --git a/credential-cache--daemon.c b/credential-cache--daemon.c index c07a67c..c2f0049 100644 --- a/credential-cache--daemon.c +++ b/credential-cache--daemon.c@@ -212,8 +212,10 @@ static void serve_cache(const char *socket_path, int debug) printf("ok\n"); fclose(stdout); - if (!debug) - freopen("/dev/null", "w", stderr); + if (!debug) { + if (!freopen("/dev/null", "w", stderr)) + die_errno("unable to point stderr to /dev/null"); + } while (serve_cache_loop(fd)) ; /* nothing */